https://bugzilla.redhat.com/show_bug.cgi?id=1421413



--- Comment #16 from Jaroslav Škarvada <[email protected]> ---
(In reply to Frank Crawford from comment #15)
> (In reply to Jaroslav Škarvada from comment #12)
> > Created attachment 1299753 [details]
> > Drop buildroot from build
> > 
> > Thanks, could you apply the attached patch? It removes the buildroot from
> > the build phase, i.e. it fixes rpmlint and shortcircuit builds with
> > different destdir.
> 
> Just for my knowledge aside from rpmlint's complaint, what is the issue with
> the use of %{buildroot} in the %build step?

You can directly run %install stage with various different %buildroot and skip
previous %prep and %build steps. I.e. %buildroot is for install. By using
%buildroot in %build you cannot change it later and run (or re-run %install)
with different %buildroot.

In practice it will usually work in both cases, but it's logically incorrect
and rpmlint is correctly complaining.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to