https://bugzilla.redhat.com/show_bug.cgi?id=1471598

Iwicki Artur <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #4 from Iwicki Artur <[email protected]> ---
>Group: Applications
>BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
The Group: and BuildRoot: tags should not be used. 
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections

>License: GPL
You need to specify the licence version.
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#GPL_and_LGPL

>Source0: %{name}-%{version}.tar.gz
Downloadable URLs are preferred. If not possible, have a comment describing how
to generate the tarball.
https://fedoraproject.org/wiki/Packaging:SourceURL

>grub2-mkconfig
I believe this calls for a "Requires: grub2-tools".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to