https://bugzilla.redhat.com/show_bug.cgi?id=1341662
--- Comment #14 from Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> ---
> so the only option would be to use master.zip link provided by Github.
That's generally OK, except that you link to an archive for a specific commit
(master is a moving target, and we need things to be reproducible). This should
work:
%global commit b314c8a2ffc643d27da0f6d75981cb784fac8374
%global shortcommit %(c=%{commit}; echo ${c:0:7})
https://github.com/developer-portal/content/archive/%{commit}/fedora-developer-portal-%{shortcommit}.tar.gz
There are guidelines
[https://fedoraproject.org/wiki/Packaging:SourceURL#Commit_Revision], but they
are slightly out of date, because github now allows nicer syntax. I'll file an
FPC bug for that.
Oh, another thing: don't use %define
[https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define].
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
