https://bugzilla.redhat.com/show_bug.cgi?id=1475228
Robert-André Mauchin <zebo...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |zebo...@gmail.com
--- Comment #2 from Robert-André Mauchin <zebo...@gmail.com> ---
Hello,
A couple of points first:
- Systemd service files should be installed in %{_unitdir}. See
https://fedoraproject.org/wiki/Packaging:Systemd#Filesystem_locations
- Systemd service files also need specific scriptlets. See
https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSnippets#Systemd
- GCC is not needed as a BuildRequire. See:
http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
- why do you define %global pkg_prefix tpm2-abrmd instead of using %{name} ?
- you can replace ./bootstrap with "autoreconf -vif" in %build
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
