https://bugzilla.redhat.com/show_bug.cgi?id=1475564

Randy Barlow <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
              Flags|                            |needinfo?([email protected])



--- Comment #2 from Randy Barlow <[email protected]> ---
There is only one thing that must be fixed for approval: the package does need
py.test so it should Require it.

Other than that, I had a few optional suggestions:

* If you use github for Source0, you can include the LICENSE file. It
introduces
  some other questions though, since the git repo contains other packages too.
See
  the attached review.txt for details.
* I recommend filing a bug against python3 to get it to own the __pycache__
folder.

Anyways, I'm prepared to approve if you add the requirements on py.test.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to