https://bugzilla.redhat.com/show_bug.cgi?id=1475483

Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |zbys...@in.waw.pl
           Assignee|nob...@fedoraproject.org    |zbys...@in.waw.pl
              Flags|                            |fedora-review?



--- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> ---
http://wiki.qt.io/Qbs → https://
http://download.qt.io/official_releases/ → https://

> LGPLv2 and LGPLv3, with exceptions

I think this should be "LGPLv2 with exceptions and LGPLv3 with exceptions"
(following
https://fedoraproject.org/wiki/Licensing:Main#Software_License_List).

> # qbs was previously packaged as part of qt-creator, using the qt-creator 
> version
> Obsoletes:      %{name} < 0:4.4.0

Shouldn't this be "qt-creator < 0:4.4.0" instead?
Also, note that the new qt-creator package should have Obsoletes: %{name} <
0:4.4.0, so called self-obsoletes, so that both packages are installed during
upgrade.

s/Examples for projects/Example projects/

https://fedoraproject.org/wiki/Packaging:Scriptlets#Shared_libraries are
needed.

Looks good otherwise.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to