https://bugzilla.redhat.com/show_bug.cgi?id=1421044



--- Comment #3 from Zbigniew Jędrzejewski-Szmek <[email protected]> ---
- No need to use underscores in %_commit, %_shortcommit.

- F24 is (almost) out, so you can remove the F24-specific workarounds.

- Group:, %defattr(-,root,root,-) → please remove
[https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections]

- qt5-qtquick1 package has been retired
[http://pkgs.fedoraproject.org/cgit/rpms/qt5-qtquick1.git/commit/?id=10624544e5e08a7d917f628733ef3e614a8532dd].
I rebuilt this package without that dependency, and it seems to build fine, but
I don't know it there's any effect. Please check.

- The %description doesn't describe the package: it also contains a D-bus
activated service. Please describe what the package does more fully.

- deepin-dialog says:
QQmlComponent: Component is not ready
"qrc:///qml/main.qml:46 Type DDialogBox
unavailable\nfile:///usr/lib64/qt5/qml/Deepin/Widgets/DDialogBox.qml:11 module
\"QtGraphicalEffects\" is not installed\n"
→ I think you need
Requires: qt5-qtgraphicaleffects(?%_isa)
Requires: qt5-qtquickcontrols(?%_isa)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to