https://bugzilla.redhat.com/show_bug.cgi?id=1424482



--- Comment #5 from Julien Nicoulaud <julien.nicoul...@gmail.com> ---
I could test the package and see no issue with it.

Especially, I appreciate:
 - Clean management for multiple cells, which is not the case in other SGE RPMs
I have seen
 - A libdrmaa.so symlink is provided, some other RPM packaging only provide
libdrmaa.so.1.0, which breaks the JGDI API as the Java code explicitly looks
for libdrmaa.so. Please keep it that way.

Some small details:
 - in /etc/profile.d/sge.*, is it possible to export SGE_QMASTER_PORT as well ?
This is needed by tools that interface with SGE via its API.
 - Some stuff is named "sge" (eg: service files, profile.d files), some
"gridengine" (eg: root dir, spool dir, lib dir, sysconfig). Maybe it would be
more consistent to just name everything "sge" (since environment variables
start with SGE_ anyway).

About the naming, maybe this package could have been named "soge" to avoid any
sort of confusion. But since SoGE is the only remaining alive open source fork
of SGE, "sge" is also fine.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to