https://bugzilla.redhat.com/show_bug.cgi?id=1475961
Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |POST
Flags|fedora-review? |fedora-review+
--- Comment #5 from Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> ---
+ package name is OK
+ license is acceptable for Fedora (MIT)
+ license is specified correctly
+ %license macro is used
+ builds and installs OK
+ P/R/BR look correct
+ scriptlets follow the guidelines
The source tarball contains a pre-compiled library: igfxcmjit32.so,
igfxcmjit64.so. That library is not present in the resulting binary rpm. Those
libs are BSD licensed. So it is not a problem that they are in the src rpm, as
long as they are not used.
I'm not sure what the effect of the lack of those precompiled objects is. I
hope cmrt is still usable without them. Debian packages is like that, so I
assume that it is.
Package is APPROVED.
A note for the future: please link directly to the raw spec file. Otherwise,
fedora-review and other tools have trouble. Also, koji scratch builds are not
good for the srpm. They are garbage-collected after a few weeks, and the srpm
should stay around "forever". Sometimes reviews get stalled, and the original
submitter goes away, and as a general policy it's good for another submitter or
reviewer to just pick the review up again at any time.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
