--- Comment #6 from Ye Cheng <> ---
Please submit the review requests of the following packages(and add them on    
   depends on field), so the package won't have broken dependencies when

Please use BuildRequires: pkgconfig(gtk+-3.0) instead of BuildRequires: 
gtk3-devel for all the libraries located using pkg-config, because the
dependency won't break when the name of the package providing the library was
changed when coded this way.
> Makefile:12
> LDFLAGS = $(shell pkg-config --libs gio-2.0 gtk+-3.0 gdk-pixbuf-xlib-2.0 x11 
> xi >xfixes xcursor libcanberra cairo-ft poppler-glib librsvg-2.0)
>BuildRequires:  gtk3-devel 
Please refer to
for detail.

Please avoid hard-coded path if possile
>%make_install SYSTEMD_LIB_DIR="/usr/lib" LIBDIR="/libexec"
A better way is to use SYSTEMD_SERVICE_DIR ="%{_unitdir}" instead of
SYSTEMD_LIB_DIR="/usr/lib" as it is supported in Makefile. 
I don't know whether it is acceptable to code LIBDIR="/libexec" as

The pakage dose not honor the applicable compiler flags 
>GOBUILD = go build -compiler gccgo -gccgoflags "${LDFLAGS}"
export GOBUILD=$(%gobuild | sed 's|${LDFLAGS:-}|${LDFLAGS}|') could be a quick
fix if it can be built with gc, compile using gccgo may require some tweaks on
%gobuild evaluates to rpm --eval %gobuild :
%ifnarch ppc64 
go build -buildmode pie -compiler gc -tags=rpm_crashtraceback -ldflags
"${LDFLAGS:-} -B 0x$(head -c20 /dev/urandom|od -An -tx1|tr -d ' \n')
-extldflags '-Wl,-z,relro -specs=/usr/lib/rpm/redhat/redhat-hardened-ld'" -a -v
-x ;
go build -compiler gc -tags=rpm_crashtraceback -ldflags "${LDFLAGS:-} -B
0x$(head -c20 /dev/urandom|od -An -tx1|tr -d ' \n') -extldflags '-Wl,-z,relro
-specs=/usr/lib/rpm/redhat/redhat-hardened-ld'" -a -v -x ;

This package should conform Go packaging
ExclusiveArch:  %{go_arches} should be added; a better way to write build
requires: gcc-go and golang-deepin-go-lib-devel  is  compiler(gcc-go) and
golang(, etc ...

You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
package-review mailing list --
To unsubscribe send an email to

Reply via email to