https://bugzilla.redhat.com/show_bug.cgi?id=1471561

Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |zbys...@in.waw.pl
           Assignee|nob...@fedoraproject.org    |zbys...@in.waw.pl



--- Comment #2 from Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> ---
No need to define %sum: just use Summary normally, and then %summary wherever
necessary.

I'd do something like
%global _description \
The python-oletools is a package of python tools from Philippe Lagadec\
to analyze Microsoft OLE2 files (also called Structured Storage,\
...

%description %_description
%description -n python2-%{gitname} %_description
%description -n python3-%{gitname} %_description
to avoid repeating the same text 3 times.

Are you sure that both python2 and python3 versions of the executables should
be installed? I'd expect to get the same output from either version, so it
should be enough to just package one of them (python2 it seems).
If you package both, it'd be better to use the suffixes recommended by
https://fedoraproject.org/wiki/Packaging:Python#Executables_in_.2Fusr.2Fbin:
-3.6, -3, -2.7, -2.

/usr/lib/python3.6/site-packages/oletools/LICENSE.txt
should be marked as %license, and
/usr/lib/python3.6/site-packages/oletools/README.rst
/usr/lib/python3.6/site-packages/oletools/README.html
should be in %doc or removed.

It seems you also need
Provides: bundled(DridexUrlDecoder)
Provides: bundled(tablestream)
Provides: bundled(xglob)
Provides: bundled(xxxswf)
Provides: bundled(zipfile27)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to