https://bugzilla.redhat.com/show_bug.cgi?id=1441728
Kalev Lember <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |[email protected] Assignee|[email protected] |[email protected] Flags| |fedora-review+ --- Comment #18 from Kalev Lember <[email protected]> --- Packaging looks nice and clean to me. Approving based on Jan Kalina's unofficial review above. I'd maybe change two minor things, one is that %if 0%{?usesnapshot} %autosetup -n %name-%{commit0} %else %setup -q %endif ... seems a bit unsymmetrical; would be easier to read if both were %autosetup (or both were %setup -q) but not a mix like this. The other minor thing is that -devel package doesn't need to contain '%license LICENSE' since it's already included in the base package. Feel free to change these if you want after importing. APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected]
