https://bugzilla.redhat.com/show_bug.cgi?id=1468873

Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
                 CC|                            |zbys...@in.waw.pl
             Blocks|177841 (FE-NEEDSPONSOR)     |
           Assignee|nob...@fedoraproject.org    |zbys...@in.waw.pl
              Flags|                            |fedora-review+



--- Comment #2 from Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> ---
I like the following trick:
%global _description \
An extension module for click to register external CLI commands via setuptools\
entry-points.

%description %_description
%description -n python2-%{srcname} %_description
%description -n python3-%{srcname} %_description

... but of course repeating the description text is OK.

Minor nitpick: the description line is very long, dnf list will look ugly.
What about: "Click extension to register CLI commands via setuptools"?

This is nice and straightforward:
+ package name is OK
+ license is acceptable for Fedora (MIT)
+ license is specified correctly
+ follows the modern python packaging template
+ builds and installs OK
+ no scriptlets needed
+ %check is present and passes
+ %license macro is used
+ %python_provide is used

rpmlint:
Only false positive ramblings about toadstools.

Package is APPROVED.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to