https://bugzilla.redhat.com/show_bug.cgi?id=1480961

Zbigniew JÄ™drzejewski-Szmek <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
                 CC|                            |[email protected]
           Assignee|[email protected]    |[email protected]
              Flags|                            |fedora-review+



--- Comment #1 from Zbigniew JÄ™drzejewski-Szmek <[email protected]> ---
rpmlint:
> golang-github-howeyc-fsnotify.src: W: summary-ended-with-dot C File change 
> notification Go language Binding.
> golang-github-howeyc-fsnotify.src: W: invalid-license fsnotify Authors
It actually is "BSD 3-clause": License: BSD.

I'm very green with go packaging, but afaict the guidelines in
https://fedoraproject.org/wiki/PackagingDrafts/Go are all followed.

+ latest version
+ package name is OK
+ license is acceptable
- license is specified incorrectly, please fix when importing
+ builds and installs OK
+ Go guideline draft is followed
+ %check does not pass but is commented out
+ BR/R/P look OK

Wouldn't it be better to change the %gotest line to something like:
{ %gotest %{import_path} } || :
so that the failures show up in the logs and it's known what needs fixing?

Package is APPROVED. Please fix license tag when uploading.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to