https://bugzilla.redhat.com/show_bug.cgi?id=1480958

Zbigniew JÄ™drzejewski-Szmek <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
                 CC|                            |[email protected]
           Assignee|[email protected]    |[email protected]
              Flags|                            |fedora-review+



--- Comment #1 from Zbigniew JÄ™drzejewski-Szmek <[email protected]> ---
Shouldn't the Release tag include the git hash? There seems to be no released
version.

- Package does not contain duplicates in %files.
  Note: warning: File listed twice:
  /usr/share/gocode/src/github.com/BurntSushi/freetype-go
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles

License tag is incomplete:
https://github.com/BurntSushi/freetype-go/blob/master/LICENSE says GPLv2+ or
"The FreeType License". This is the same offer that freetype provides. I think
it should be "License: GPLv2+ or FTL".

+ package name is OK
+ license is acceptable (see above)
- license is not specified correctly
+ latest version
+ P/R/BR look OK
+ builds and install OK
+ fedora-review and rmplint are happy (modulo the issue listed above)

rpmlint:
golang-github-BurntSushi-freetype-go-unit-test-devel.x86_64: W:
no-documentation
3 packages and 0 specfiles checked; 0 errors, 1 warnings.

Package is APPROVED. Please fix the License and Release tags when importing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to