Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226547 --- Comment #17 from Parag AN(पराग) <[email protected]> 2010-10-02 03:38:01 EDT --- Following are the changes proposed in above patch 1) Guidelines suggests to keep timestamps of upstream installed files. So please use install -p See https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps 2) Guidelines suggests package built above F-13 do not need %clean, buildroot and cleaning of buildroot See https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean http://fedoraproject.org/wiki/PackagingGuidelines#BuildRoot_tag 3) Guidelines recommends defattr usage as %defattr(-, root, root,-) See https://fedoraproject.org/wiki/Packaging/Guidelines#File_Permissions -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
