https://bugzilla.redhat.com/show_bug.cgi?id=1431868



--- Comment #7 from Fabio Valentini <[email protected]> ---
- Supplements vs. Recommends:

There was a reason, because no syncthing-inotify existed in fedora when I built
syncthing, and adding "Recommends" on a third-party package is forbidden.

Since both packages will soon be in the official fedora repositories, I can
remove the "Supplements" tag from syncthing-inotify and then add a "Recommends"
tag to syncthing once the syncthing-inotify package is in the repositories.

- Wrong permissions on patch:

Sorry about that, I didn't notice. The patch is the autogenerated one from the
github pull request, and I didn't check for file permissions (who would?).


Remaining rpmlint issues when built locally in mock:

- Spelling error (synchronisation, rescan): The text is from the upstream
README. I don't want to change "fix" it downstream.

- Hardcoded library path: No way around this, but systemd will soon (TM) ship
the missing macro to fix this. And in a way, this is a false positive anyway.

The rest of the message are false positives.


Spec URL: https://decathorpe.fedorapeople.org/packages/syncthing-inotify.spec

SRPM URL:
https://decathorpe.fedorapeople.org/packages/syncthing-inotify-0.8.7-4.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to