https://bugzilla.redhat.com/show_bug.cgi?id=1483298

Robert-AndrĂ© Mauchin <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #1 from Robert-AndrĂ© Mauchin <[email protected]> ---
Hello,

Some similar issues as before:

 - You must post both SPEC URL and SRPM URL. It's used by fedora review to
fetch the files from a bug number.
 - The latest version is 4.1.7, not 4.1.6
 - Just use: %global repo dde-launcher
 - Use pkgconfig where you can:

BuildRequires:  pkgconfig(dtkbase)
BuildRequires:  pkgconfig(dframeworkdbus)
BuildRequires:  pkgconfig(gsettings-qt)
BuildRequires:  pkgconfig(gtk+-2.0)
BuildRequires:  qt5-linguist
BuildRequires:  pkgconfig(Qt5)
BuildRequires:  pkgconfig(Qt5Svg)
BuildRequires:  pkgconfig(Qt5X11Extras)
BuildRequires:  pkgconfig(xcb-ewmh)

 - If you install icons your must run the scriptlets described in this section:
https://fedoraproject.org/wiki/Packaging:Scriptlets#Icon_Cache
 You also need to add a: Requires:       hicolor-icon-theme

 - I wasn't able to build the project because it seems a BR is missing:

Project ERROR: dtkcore development package not found

Have you packaged this yet? https://github.com/linuxdeepin/dtkcore

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to