https://bugzilla.redhat.com/show_bug.cgi?id=1483459



--- Comment #2 from Jakub Jedelsky <[email protected]> ---
Hi Robert,

thanks for a quick review. I updated the SPEC and SRPM from the first comment.

(In reply to Robert-André Mauchin from comment #1)
>  - Please use spaces instead of tabs

done

>  - The Group: tag is not needed in Fedora. See
> https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections . If
> you're also packaging for RHEL, just put it inside a condition.

removed

>  - Please use a more meaningful name for your archive, use:
> 
> Source0:   
> https://github.com/baztian/%{srcname}/archive/v%{version}/%{name}-%{version}.
> tar.gz

This is cool, I didn't realized it is possible this way. Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to