https://bugzilla.redhat.com/show_bug.cgi?id=1471156

Robert-AndrĂ© Mauchin <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #1 from Robert-AndrĂ© Mauchin <[email protected]> ---
Hello,


 - Why do you have:

%postun
/sbin/ldconfig

  There is no .so in this app, no need for ldconfig

  - gtk-update-icon-cache must be run in %post and %postun, not in %trans See
the scriplet
https://fedoraproject.org/wiki/PackagingDrafts/ScriptletSnippets#GTK.2B_icon_cache

  - update-mime-database is not needed in %trans either.

  - it would be great to include an Appdata file. See
https://fedoraproject.org/wiki/Packaging:AppData

  - There are several files under BSD:

BSD (3 clause)
--------------
berry/asemantools/qml/AsemanTools/Controls/Styles/Desktop/CalendarStyle.qml
berry/asemantools/qml/AsemanTools/Controls/Styles/Desktop/FocusFrameStyle.qml
berry/asemantools/qml/AsemanTools/Controls/Styles/Desktop/MenuBarStyle.qml
berry/asemantools/qml/AsemanTools/Controls/Styles/Desktop/SliderStyle.qml
berry/asemantools/qml/AsemanTools/Controls/Styles/Desktop/StatusBarStyle.qml
berry/asemantools/qml/AsemanTools/Controls/Styles/Desktop/TableViewStyle.qml
berry/asemantools/qml/AsemanTools/Controls/Styles/Desktop/TextAreaStyle.qml
berry/asemantools/qml/AsemanTools/Controls/Styles/Desktop/ToolBarStyle.qml

  Please include it in License: and detail what each license covers.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to