https://bugzilla.redhat.com/show_bug.cgi?id=1476565

Robert-André Mauchin <zebo...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zebo...@gmail.com



--- Comment #3 from Robert-André Mauchin <zebo...@gmail.com> ---
Hello,

Could you explain a bit why you package a specific git commit instead of the
Release 3.1.7? I understand that you need old files for F25, but why the "new"
files aren't coming from the Release?

Also, you need to remove the Group: tag, no needed in Fedora.

It would be nice to change the BR to use pkgconfig, and fix the BR for
deepin-go-lib:

BuildRequires:  golang(pkg.deepin.io/lib)
BuildRequires:  deepin-dbus-generator
# For dbus-factory 3.0.6
BuildRequires:  pkgconfig(Qt5)
BuildRequires:  pkgconfig(Qt5Qml)
BuildRequires:  pkgconfig(Qt5WebKit)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to