https://bugzilla.redhat.com/show_bug.cgi?id=1484421

Iwicki Artur <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #1 from Iwicki Artur <[email protected]> ---
>%{_datadir}/fwts/*
This will mark all the files inside the directory as owned, but not the
directory itself. Removing the wildcard will own the directory and all files
within.
https://fedoraproject.org/wiki/Packaging:UnownedDirectories#Wildcarding_Files_inside_a_Created_Directory

>%setup -a 0 -n fwts-%{version} -c
I believe the -n option is unnecessary here; "%{name}-%{version}" is the
default. 

Are are no files marked as %license. I took a look at the source and it seems
that upstream does not provide the licence text. You should inquire them to
include it. 

The README* files could probably be included in the package as %doc files.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to