https://bugzilla.redhat.com/show_bug.cgi?id=1297852
Robert-André Mauchin <zebo...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |zebo...@gmail.com
Assignee|williamjmore...@gmail.com |zebo...@gmail.com
--- Comment #8 from Robert-André Mauchin <zebo...@gmail.com> ---
Hello,
- The Group: tag is not needed on Fedora. See:
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections
- You could use the %{py2_dist/%{py3_dist macros for your dependencies. See:
https://fedoraproject.org/wiki/Packaging:Python#Requires_and_BuildRequires_with_standardized_names
i.e. like this:
BuildRequires: python-setuptools
BuildRequires: python2-devel
# Needed to build documentation
%if 0%{?_with_doc}
BuildRequires: %{py2_dist pip}
BuildRequires: %{py2_dist sphinx}
BuildRequires: %{py2_dist sphinx-rtd-theme}
%endif
%if 0%{?_with_python3}
BuildRequires: python3-devel
%endif
# Needed for tests
%if 0%{?_with_tests}
BuildRequires: %{py2_dist certifi}
BuildRequires: %{py2_dist chardet}
BuildRequires: %{py2_dist coverage}
BuildRequires: %{py2_dist enum34}
BuildRequires: %{py2_dist isodate}
BuildRequires: %{py2_dist keyring}
BuildRequires: %{py2_dist msrest}
BuildRequires: %{py2_dist msrestazure}
BuildRequires: %{py2_dist nose}
BuildRequires: %{py2_dist oauthlib}
BuildRequires: %{py2_dist requests}
BuildRequires: %{py2_dist requests-oauthlib}
BuildRequires: %{py2_dist vcrpy} >= 1.8.0
%if 0%{?_with_python3}
BuildRequires: %{py3_dist certifi}
BuildRequires: %{py3_dist chardet}
BuildRequires: %{py3_dist coverage}
BuildRequires: %{py3_dist isodate}
BuildRequires: %{py3_dist keyring}
BuildRequires: %{py3_dist msrest}
BuildRequires: %{py3_dist msrestazure}
BuildRequires: %{py3_dist nose}
BuildRequires: %{py3_dist oauthlib}
BuildRequires: %{py3_dist requests}
BuildRequires: %{py3_dist requests-oauthlib}
BuildRequires: %{py3_dist vcrpy} >= 1.8.0
%endif
%endif
BuildArch: noarch
%description
%{common_description}
%package -n python2-%{srcname}
Summary: %{common_summary}
Requires: pyOpenSSL
Requires: %{py2_dist msrest}
Requires: %{py2_dist msrestazure}
Requires: %{py2_dist requests}
%{?python_provide:%python_provide python2-%{srcname}}
%description -n python2-%{srcname}
%{common_description}
%if 0%{?_with_python3}
%package -n python3-%{srcname}
Summary: %{common_summary}
Requires: %{py3_dist msrest}
Requires: %{py3_dist msrestazure}
Requires: %{py3_dist pyOpenSSL}
Requires: %{py3_dist requests}
%{?python_provide:%python_provide python3-%{srcname}}
- You should use the %make_build macro instead of make alone
%make_build -C doc/ html
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT/X11 (BSD like)", "Apache (v2.0)", "Unknown or generated".
4432 files have unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/python-azure-sdk/review-python-azure-
sdk/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 102400 bytes in 6 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic:
[!]: Uses parallel make %{?_smp_mflags} macro.
[x]: Avoid bundling fonts in non-fonts packages.
Note: Package contains font files
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2
-azure-sdk , python3-azure-sdk , python-azure-sdk-doc
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: No rpmlint messages.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: python2-azure-sdk-2.0.0-1.fc28.noarch.rpm
python3-azure-sdk-2.0.0-1.fc28.noarch.rpm
python-azure-sdk-doc-2.0.0-1.fc28.noarch.rpm
python-azure-sdk-2.0.0-1.fc28.src.rpm
4 packages and 0 specfiles checked; 0 errors, 0 warnings.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
