https://bugzilla.redhat.com/show_bug.cgi?id=843646



--- Comment #8 from Ben Rosser <[email protected]> ---
Okay, great.

According to https://activities.sugarlabs.org/en-US/sugar/addon/4587, the
latest version is "7"; the package listed here is version "2". If you are
interested in continuing the review, please update the package to the latest
version.

Also please look through the package and identify any bundled code and
libraries. Fedora policy no longer *requires* removing bundled libraries but it
strongly encourages it if possible. If it's not possible through, you MUST add
lines of the following form to your spec:

Provides: bundled(name) = version

Where "name" is the name of the bundled library and "version" the version (omit
version if you cannot determine one). You MUST also update the License tag
accordingly with the bundled licenses.

https://fedoraproject.org/wiki/Packaging:Guidelines#Bundling_and_Duplication_of_system_libraries

https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License:_field

Also, note that you can now replace "%{__python} ./setup.py build" with
"%py2_build".

Please make these changes, and I will be happy to review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to