https://bugzilla.redhat.com/show_bug.cgi?id=1358741



--- Comment #11 from Mohamed El Morabity <[email protected]> ---
Thanks for taking over the review.

(In reply to Robert-André Mauchin from comment #10)
>  - Bump to version 0.4.13. You'll need to add a BR to python-httpretty for
> the tests.
Updated. The BR was already available in previous versions.

>  - The Group: tag is not needed on Fedora. See:
> https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections
Not needed anymore but not forbidden :).

>  - You could use the %{py2_dist/%{py3_dist macros for your dependencies.
> See: 
> https://fedoraproject.org/wiki/Packaging:
> Python#Requires_and_BuildRequires_with_standardized_names
The packages were submitted before guidelines changes. Anayway I'd like to keep
the same spec file for both Fedora and EPEL. I rely then on
https://fedoraproject.org/wiki/FinalizingFedoraSwitchtoPython3#Q.26A to better
handle Python dependencies.

Spec file:
https://copr-be.cloud.fedoraproject.org/results/melmorabity/azure/fedora-rawhide-x86_64/00595483-python-msrestazure/python-msrestazure.spec

SRPM file:
https://copr-be.cloud.fedoraproject.org/results/melmorabity/azure/fedora-rawhide-x86_64/00595483-python-msrestazure/python-msrestazure-0.4.13-1.fc28.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to