https://bugzilla.redhat.com/show_bug.cgi?id=1490054
--- Comment #2 from Alexander Ploumistos <alex.ploumis...@gmail.com> ---
Hello Artur,
Thanks for looking into this.
(In reply to Iwicki Artur from comment #1)
> >%{__mkdir_p}
> >%{__cp} -p
> >...
> "Macro forms of system executables SHOULD NOT be used except when there is a
> need to allow the location of those executables to be configurable."
> https://fedoraproject.org/wiki/Packaging:Guidelines#Macros
I think I had picked this up from firefox's spec file. I had seen the section
you have quoted, but as I was uncertain about the part of needing "to allow the
location of those executables to be configurable", I went with that. Should
those be plain cp or /usr/bin/cp instead?
> The "x-sciprj.desktop" file is not passed through desktop-file-validate - is
> this intentional?
When I first saw this file, I noticed it wasn't a "regular" desktop file and
the only thing on the wiki about its location (/usr/share/mimelnk) was this KDE
SIG page
https://fedoraproject.org/wiki/SIGs/KDE/Packaging/Cleanup
so I just left it there. Now that you've mentioned it, I can't find anything
about desktop files referencing only mimetypes on freedesktop.org, plus on my
fedora machines, all the subdirectories under /usr/share/mimelnk are empty;
only on one of them, that has been updated since f17 or f19, I have some
mimetype.desktop files, which date back to 2008. So, I guess they might have
been deprecated in the meantime and the file should be removed? Do you know
something about any of that?
> Apart from those two issues, seems fine to me.
Do you have any insights on those "File listed twice" warnings?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
