https://bugzilla.redhat.com/show_bug.cgi?id=1454925
Robert-André Mauchin <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |[email protected] Assignee|[email protected] |[email protected] Flags| |fedora-review? --- Comment #1 from Robert-André Mauchin <[email protected]> --- Hello, - Group: is not used in Fedora. See: https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections - Release is missing its dist tag: Release: 3%{?dist} - Latest version is no 2.14. Please bump your SPEC accordingly: Version: 2.14 Release: 1%{?dist} > The project's home is on github and releases are done there (via tags), but > the project also uses git submodules and these are then not included in the > source tarball. You should detail the steps you've made to get to the final archive, or include a script to achieve this. I used git-archive-all to generate the tar.gz, since your SRPM is 404ing. - You're including a user unit file, you thus must run the systemd scripplets in %post, %preun, %postun. See: https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSnippets#Systemd First add the special BR/macro for systemd: %{?systemd_requires} BuildRequires: systemd Then add the scriplets: %post %systemd_post %{name}.service %preun %systemd_preun %{name}.service %postun %systemd_postun_with_restart %{name}.service Anyhow, I'd like an updated SPEC and SRPM to continue the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected]
