https://bugzilla.redhat.com/show_bug.cgi?id=1438659

Robert-André Mauchin <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #1 from Robert-André Mauchin <[email protected]> ---
Hello,


 - Please bump to latest version 0.9.1

 - Please use a more meaningful name for your archive, just like this:

Source0:       
https://github.com/astroidmail/%{name}/archive/v%{version}/%{name}-%{version}.tar.gz

 - You're installing icons in hicolors, you must run gtk-update-icon-cache.
See:
https://fedoraproject.org/wiki/PackagingDrafts/ScriptletSnippets#GTK.2B_icon_cache

%post
touch --no-create %{_datadir}/icons/hicolor || :
if [ -x %{_bindir}/gtk-update-icon-cache ] ; then
%{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
fi

%postun
touch --no-create %{_datadir}/icons/hicolor || :
if [ -x %{_bindir}/gtk-update-icon-cache ] ; then
%{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
fi

 - You're installing a .desktop file, you must run desktop-file-validate. See:
https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage


desktop-file-validate %{buildroot}/%{_datadir}/applications/%{name}.desktop

 - %{_datarootdir} → %{_datadir}

 - webkitgtk and webkitgtk3 have been retired due to security issues. See:
https://lists.fedoraproject.org/archives/list/[email protected]/thread/AKVB363GFCHHJ5MTHGVYHYT6NLLTF5VM/

  Please port the package to WebKit2. This is non-trivial work. It seems to be
in the "project" of upstream:
https://github.com/astroidmail/astroid/projects/1#card-2220439

 Until then, the package can't be included in Rawhide.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to