Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=626666

Mamoru Tasaka <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #11 from Mamoru Tasaka <[email protected]> 2010-10-06 
14:30:53 EDT ---
Okay. For -6:

* %files
  - %install says:
-----------------------------------------------------------
mkdir -p $RPM_BUILD_ROOT%{_localstatedir}/lib/groonga/db
-----------------------------------------------------------
    Maybe it is better that also %dir %{_localstatedir}/lib/groonga/db
    is added to %files list for main package.

* Macros
------------------------------------------------------------
/usr/sbin/munin-node-configure --shell --remove-also | grep -e 'groonga_' | sh
------------------------------------------------------------
  - Please use %{_sbindir} for /usr/sbin

------------------------------------------------------------
    This directory (groonga) is APPROVED by mtasaka
------------------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to