https://bugzilla.redhat.com/show_bug.cgi?id=1417631

Robert-AndrĂ© Mauchin <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[email protected]
           Assignee|[email protected]    |[email protected]
              Flags|                            |fedora-review?



--- Comment #2 from Robert-AndrĂ© Mauchin <[email protected]> ---
Hello,

  - As before, list of things not needed in Fedora:

    + Group:          System Environment/Libraries
    + BuildRoot:     
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
    + rm -rf $RPM_BUILD_ROOT
    + %clean
    + %defattr(-,root,root,-)

 - You need to include the various license files in %license:

%license LICENSE COPYING.LIB COPYING.GPL

 - The License: field should reflect the licenses included, that is, the C++
wrapper "ftdipp1" is distributed under the GNU General Public License version 2
and the C library "libftdi1" is distributed under the GNU Library General
Public License version 2:

License: GPLv2 and LGPLv2

 - %doc should probably include:

%doc AUTHORS ChangeLog README

 - You should probably not include the full documentation at all, which comes
at a hefty 12MB. See
https://fedoraproject.org/wiki/Packaging:MinGW#Files_which_are_already_part_of_native_packages

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to