https://bugzilla.redhat.com/show_bug.cgi?id=1362491

Robert-AndrĂ© Mauchin <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #5 from Robert-AndrĂ© Mauchin <[email protected]> ---
Hello,

I'm not familiar with EPEL requirements, so ignore the things not applying to
it.

 - Not needed in Fedora:

   + Group:

   + rm -rf %{buildroot} in %install

   + %clean
     rm -rf %{buildroot}

   + %{!?_licensedir:%global license %doc}

 See: https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections

 - Maybe you should refresh to a more recent git revision.

 - Use systemd macros, use:

%{?systemd_requires}
BuildRequires: systemd

   instead of:

Requires(post):     systemd-units
Requires(postun):   systemd-units
Requires(preun):    systemd-units

BuildRequires:      systemd

 - You should probably clean up all the commented out part.

 - The release tag should start with 0.1 and so on:

Version:            0.1.%{revision_date}.git%{git_short_version_hash}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to