https://bugzilla.redhat.com/show_bug.cgi?id=1501500
--- Comment #2 from Lokesh Mandvekar <l...@redhat.com> ---
===== MUST items =====
C/C++:
[-]: Package does not contain kernel modules.
[-]: Package contains no static executables.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Apache (v2.0)", "CC by-sa (v4.0)", "*No copyright* BSD (2
clause)", "Unknown or generated", "MIT/X11 (BSD like)", "ISC", "BSD (3
clause)", "BSD (2 clause)", "do What The Fuck you want to Public
License (v2)", "*No copyright* Apache (v2.0)". 1241 files have unknown
license. Detailed output of licensecheck in
/home/lsm5/reviews/1501500-containerd/licensecheck.txt
[!]: Package requires other packages for directories it uses.
Note: No known owner of /etc/containerd
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /etc/containerd
Owning /etc/containerd should make these two go away.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[!]: Requires correct, justified where necessary.
See the Requires section below.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
Requires
--------
containerd (rpmlib, GLIBC filtered):
/bin/sh
config(containerd)
libc.so.6()(64bit)
libdl.so.2()(64bit)
libpthread.so.0()(64bit)
rtld(GNU_HASH)
runc
systemd
You'll need to include systemd as a Requires since you're shipping a unitfile.
Also, probably need to include runc in there as well. Rest of them should be
automatically handled IIUC.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
