https://bugzilla.redhat.com/show_bug.cgi?id=1505306

Robert-André Mauchin <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #1 from Robert-André Mauchin <[email protected]> ---
Hello,


 - %{_prefix}/lib/udev/rules.d/ → %{_udevrulesdir}

 - BuildRequires:  hicolor-icon-theme 
   Requires:       hicolor-icon-theme 

   → Not needed, as you don't install any icons in the hicolor directory.

 - You forgot to validate i-nex.desktop:

desktop-file-validate %{buildroot}/%{_datadir}/applications/%{name}.desktop

 - You should add an AppData file. See
https://fedoraproject.org/wiki/Packaging:AppData

 - The release tag should contain the commit date too for a snapshot release:

%global gver .%{gitdate}git%{shortcommit0}

   And:

* Wed Sep 27 2017 Martin Gansser <[email protected]> -
7.6.0-1.20170703git0c10102

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to