https://bugzilla.redhat.com/show_bug.cgi?id=1506722

Nir Magnezi <nmagn...@redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nmagn...@redhat.com



--- Comment #2 from Nir Magnezi <nmagn...@redhat.com> ---
Carlos,

Initial review:

1. In other packages we have, URL points to a launchpad URL. since Octavia
migrated to storyboard, perhaps the URL should be:
https://storyboard.openstack.org/#!/project/911

2. You should end up with a separate RPM for tests, see the
python-neutronclient spec for reference:
https://github.com/rdo-packages/neutronclient-distgit/blob/26310d84ea59c383c928be5d01d350f0e21291cd/python-neutronclient.spec#L65-L130

3. Another reference can use to learn how to handle the tests deletion from the
main rpm:
https://github.com/rdo-packages/neutronclient-distgit/commit/296abb5e9aee5019ea22b4f2235f12fae2916a43

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to