https://bugzilla.redhat.com/show_bug.cgi?id=1507103

Iwicki Artur <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #5 from Iwicki Artur <[email protected]> ---
Hi, just took a quick glance.

>Group: System Environment/Base
>Group: System Environment/Libraries
>Group: Development/Libraries
The "Group" tag should not be used.

>BuildRoot: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)
The same for "BuildRoot:".

>%install
>rm -rf %{buildroot}
You shouldn't manually remove the buildroot during %install.
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections

>%doc COPYING.* COPYRIGHT 
These should probably be marked as %license.

As for fedora-review: you can try "fedora-review -rn PATH_TO_LOCAL_SRPM".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to