Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=621015 Mohammed Morsi <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?([email protected] | |) | --- Comment #6 from Mohammed Morsi <[email protected]> 2010-10-12 13:46:35 EDT --- Apologies for the delay (In reply to comment #3) > For 2.1.6-1 > > * BR > - So would you at least add "BR(check): rubygem(bcrypt-ruby)" (and > "BR: rubygem(rake)" so as to make %check section pass correctly? > > Some additional notes > * BuildRoot > - BuildRoot tag is no longer used (and needed) on Fedora and EPEL6 > https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag > > * ri files generation > - As I said in other review request (I suppose), usually we > generate ri documentation files, which can be used with > ri (in ruby-ri) command. > > * -doc files generation > - And would you consider to create -doc subpackages and move > document files (except for LICENSE, README.rdoc, CHANGELOG.rdoc) > to -doc subpackage? Everything has been taken care of. Also had to add patch1 to remove the jeweler dependency which is not needed. New uploads: Spec URL: http://mo.morsi.org/files/gems/rubygem-authlogic.spec SRPM URL: http://mo.morsi.org/files/gems/rubygem-authlogic-2.1.6-2.fc13.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2530656 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
