https://bugzilla.redhat.com/show_bug.cgi?id=1447517

Robert-André Mauchin <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #6 from Robert-André Mauchin <[email protected]> ---
 - Not sure what is this for:

rpm --version
rpmbuild --version

 - make DESTDIR=%{buildroot} install → %make_install

 - no need for %attr(755,root,root)' just:

%{_bindir}/ddcutil

 - Since you're upstream, it would be best if your install script doesn't
install anything in docdir. It's better to do it in %files like this:

%doc     AUTHORS NEWS.md README.md ChangeLog
%license COPYING

Files will then be copied automatically.
I don't know what's needed for other distro though so maybe it's not possible.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to