https://bugzilla.redhat.com/show_bug.cgi?id=1519323

Robert-André Mauchin <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #2 from Robert-André Mauchin <[email protected]> ---
The package already exists https://src.fedoraproject.org/rpms/qesteidutil but
is orphaned. Did you follow the procedure to un-orphan it?
https://fedoraproject.org/wiki/Orphaned_package_that_need_new_maintainers#Claiming_Ownership_of_a_Retired_Package

Package Review:

 - make %{?_smp_mflags} → %make_build

 - make install DESTDIR=%{buildroot} → %make_install

 - Not needed:

%clean
rm -rf %{buildroot}

 - The license file should be included with the %license macro, not %doc:

%files
%doc AUTHORS CONTRIBUTING.md README.md RELEASE-NOTES.md
%license LICENSE.LGPL

 - COPING is not needed as it is the license for the removed
qtsingleapplication bundle.

 - Please remove the excessive linebreak


 - Use pkgconfig for BR when you can:

BuildRequires:  cmake
BuildRequires:  desktop-file-utils
BuildRequires:  pkgconfig(openssl)
BuildRequires:  pkgconfig(Qt5Designer)
BuildRequires:  pkgconfig(libpcsclite) >= 1.7
BuildRequires:  libappstream-glib
BuildRequires:  qtsingleapplication-qt5-devel
Requires:       hicolor-icon-theme
Requires:       opensc%{?_isa}
Requires:       pcsc-lite-ccid%{?_isa}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to