https://bugzilla.redhat.com/show_bug.cgi?id=1268698

Jaroslav Prokop <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #1 from Jaroslav Prokop <[email protected]> ---
Hi Ilya, I did informal review on your package and I found following:

* Group is not needed
  - Group tags are not needed currently, so you should delete lines:
~~~
Group: Development/Languages
~~~

~~~
Group: Documentation
~~~

* Tests are not working
  - Tests are not working properly, because it seems upstream didn't include
spec      
    folder in the gem. Please fix this.

* Include Runtime Dependencies
  - With tests I discovered there are runtime dependencies that need to be
added.
    Please do so.

I did not discover other errors.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to