https://bugzilla.redhat.com/show_bug.cgi?id=587978



--- Comment #26 from Michal Ambroz <[email protected]> ---
SPEC URL: https://rebus.fedorapeople.org/SPECS/whatweb.spec
SRPM URL: https://rebus.fedorapeople.org/SRPMS/whatweb-0.4.9-1.fc27.src.rpm

Bump to current upstream release.

>[!]: MUST Each %files section contains %defattr if rpm < 4.4
defattr removed

>[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
cleaning of the buildroot removed

>[!]: MUST Sources used to build the package match the upstream source, as
The release should MD5 match much better than git commit ad-hoc snapshot
(please note that gzip contains timestamps so it might not be MD5 same).

>[!]: SHOULD Buildroot is not present
removed

>[!]: SHOULD Package has no %clean section with rm -rf %{buildroot} (or
removed

>[!]: SHOULD SourceX / PatchY prefixed with %{name}.
link to release source is now resulting in whatweb-0.4.9.tar.gz

>[!]: SHOULD Spec use %global instead of %define.
define changed to global


Best regards
Michal Ambroz

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to