https://bugzilla.redhat.com/show_bug.cgi?id=1517006
Christoph Junghans <jungh...@votca.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #10 from Christoph Junghans <jungh...@votca.org> ---
(In reply to Ankur Sinha (FranciscoD) from comment #9)
> (In reply to Christoph Junghans from comment #8)
> > Thanks @Sergey for looking for it! I had a look as well!
> >
> >
> > Summary:
> > =======
> > I found (nitpicks):
> > - there are tests in tests/, can we run these in %check?
>
> The tests use Xvrb, and from the looks of it, it requires X running on the
> box? I can't manage that on the Fedora builders.
Thank for the explanation!
> New spec/srpm:
> Spec URL: https://ankursinha.fedorapeople.org/vimiv/vimiv.spec
> SRPM URL:
> https://ankursinha.fedorapeople.org/vimiv/vimiv-0.9.1-4.fc27.src.rpm
>
> * Sun Dec 10 2017 Ankur Sinha <ankursinha AT fedoraproject DOT org> - 0.9.1-4
> - Remove tests - Xvfb seems to require root access and X
>
> * Sun Dec 10 2017 Ankur Sinha <ankursinha AT fedoraproject DOT org> - 0.9.1-3
> - Add tests and other corrections based on rhbz #1517006
> - update-desktop-database
> - preserve timestamps
>
> Cheers!
> Ankur
Approved.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
