https://bugzilla.redhat.com/show_bug.cgi?id=1036130



--- Comment #37 from Pavel Raiskup <[email protected]> ---
(In reply to Robert-André Mauchin from comment #36)
>  - Add a comment for each patch explaining what they do

Done inside the patch, but I added comment on top of "patch" section about
this fact; and I've split the 'patch0' into two patches (with better naming,
and per-issue purpose).

>  - Group: is not needed in Fedora. See:
> https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections

Removed.

>  - Use a more meaningful name for your archive, with the following Source0:
> 
> Source0:
> https://github.com/%{sname}/%{sname}/archive/v%{version}/%{name}-%{version}.
> tar.gz

Done, I didn't know this trick!  Thank you.

Spec URL: https://raw.githubusercontent.com/praiskup/plv8-pkg/master/plv8.spec
SRPM URL: https://praiskup.fedorapeople.org/plv8-2.1.0-4.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to