https://bugzilla.redhat.com/show_bug.cgi?id=1481630
Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |zbys...@in.waw.pl
--- Comment #44 from Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> ---
Package name should be virtualbox-guest-additions.
https://fedoraproject.org/wiki/Packaging:Naming#General_Naming says "Package
names should be in lower case" and that's the common practice nowadays.
Provides/Obsoletes for the capitalized name are enough to help people upgrade.
http://www.virtualbox.org/wiki/VirtualBox → https://
Likewise, https:// should be used for the download URL. Even if fedora-review
had some issue with the certificate, not downloading over http is more
important than what fedora-review thinks.
> # FIXME once kernel modules have landed
> #Requires: kernel >= 4.FIXME
Like kwizart already said, this can never work. You can just drop this part.
BuildRequires: systemd is necessary for %{?systemd_requires}.
96-vbox.preset must be dropped, and the preset must be added following the
normal procedue in https://fedoraproject.org/wiki/Starting_services_by_default.
> ConditionVirtualization=|oracle
Nice! This should make the package a total noop on any other system.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
