https://bugzilla.redhat.com/show_bug.cgi?id=1532837
--- Comment #2 from Miro Hrončok <mhron...@redhat.com> ---
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Check license, locale conflicts, directory ownership, see [!]s bellow.
BTW Have you checked whether it works with python3-arcus 3?
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: uranium-lulzbot-2.6.63/UM/SortedList.py is Apache (v2.0)
You are the legal expert here, so do whatever you see fit, I'd say
the package is AGPLv3+ and ASL 2.0.
[x]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
Note: No known owner of /usr/lib/python3.6/site-packages/CuraLulzbot
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib/python3.6/site-
packages/CuraLulzbot
[-]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by:
/usr/share/cmake(python3-uranium, rapidjson-devel, bash-completion,
cmake-filesystem), /usr/share/cmake/Modules(python3-uranium, cmake-
filesystem)
This is deliberate.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[!]: The spec file handles locales properly.
The locales are not renamed and some of them will conflict with
python3-uranium.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[!]: Package does not generate any conflict.
The locales will conflict.
Currently only /usr/share/locale/pt_BR/LC_MESSAGES/uranium.mo
but later, if this keeps up with upstream changes, all of them will.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[?]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[-]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic:
[x]: Uses parallel make %{?_smp_mflags} macro.
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3
-uranium-lulzbot , python-uranium-lulzbot-doc
[?]: Package functions as described.
[?]: Latest version is packaged.
[-]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[x]: SourceX tarball generation or download is documented.
Note: Package contains tarball without URL, check comments
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[?]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[-]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: python3-uranium-lulzbot-2.6.63-1.fc27.noarch.rpm
python-uranium-lulzbot-doc-2.6.63-1.fc27.noarch.rpm
python-uranium-lulzbot-2.6.63-1.fc27.src.rpm
python3-uranium-lulzbot.noarch: W: dangling-relative-symlink
/usr/share/uranium-lulzbot/resources/i18n ../../locale
python-uranium-lulzbot.src:118: E: hardcoded-library-path in
%{_prefix}/lib/%{shortname}
python-uranium-lulzbot.src: W: invalid-url Source0:
uranium-lulzbot-2.6.63.tar.gz
3 packages and 0 specfiles checked; 1 errors, 2 warnings.
All good.
Rpmlint (installed packages)
----------------------------
python3-uranium-lulzbot.noarch: W: invalid-url URL:
https://code.alephobjects.com/diffusion/U/repository/master/ <urlopen error
[Errno -2] Name or service not known>
python3-uranium-lulzbot.noarch: W: dangling-relative-symlink
/usr/share/uranium-lulzbot/resources/i18n ../../locale
python-uranium-lulzbot-doc.noarch: W: invalid-url URL:
https://code.alephobjects.com/diffusion/U/repository/master/ <urlopen error
[Errno -2] Name or service not known>
2 packages and 0 specfiles checked; 0 errors, 3 warnings.
All good (my mock is without interwebz).
Requires
--------
python3-uranium-lulzbot (rpmlib, GLIBC filtered):
python(abi) = 3.6
python3-arcus >= 2.6
python3-numpy
python3-qt5
python3-scipy
python-uranium-lulzbot-doc (rpmlib, GLIBC filtered):
Provides
--------
python3-uranium-lulzbot:
python3-uranium-lulzbot
python-uranium-lulzbot-doc:
python-uranium-lulzbot-doc
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
