https://bugzilla.redhat.com/show_bug.cgi?id=1532023



--- Comment #4 from Alec Leamas <leamas.a...@gmail.com> ---
(In reply to Antonio Trande from comment #3)
> - This package is not correctly named, see common SPEC file
>   for Python packages:
>   http://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file
>  
> https://fedoraproject.org/wiki/Packaging:Naming?rd=Packaging:
> NamingGuidelines#Python_source_package_naming

No. These guidelines applies to python modules; that is, python libraries so to
speak. It does not apply to a tool like this. There is a large number of
examples available - fedora-review, koji and dnf comes to mind (all are
python).

> - Do not use hard-coded directory names:
>   rm -rf $RPM_BUILD_ROOT/usr/share/doc/ddupdate/*

Fixed. 

Using a new upstream release. New urls:
spec: https://leamas.fedorapeople.org/ddupdate/0.2.0-1/ddupdate.spec
srpm:
https://leamas.fedorapeople.org/ddupdate/0.2.0-1/ddupdate-0.2.0-1.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to