https://bugzilla.redhat.com/show_bug.cgi?id=1540553

Robert-AndrĂ© Mauchin <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #1 from Robert-AndrĂ© Mauchin <[email protected]> ---
 - You're missing %{?dist} in Release

 - Doesn't this service require its own user and group?

 - Don't use:

Requires(post): systemd
Requires(preun): systemd
Requires(postun): systemd

   Use the provided macro instead:

%{?systemd_requires}
BuildRequires: systemd

 - Also building with vendored is a no go, you will need to unbundle each
dependency in vendor. Yes, it's gonna be a big task. Use gofed to do most of
the work.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to