https://bugzilla.redhat.com/show_bug.cgi?id=1540726



--- Comment #6 from Germano Massullo <germano.massu...@gmail.com> ---
https://germano.fedorapeople.org/package_reviews/bettercap/rev2/bettercap.spec
https://germano.fedorapeople.org/package_reviews/bettercap/rev2/bettercap-2.0.0-0.1.fc27.src.rpm

(In reply to Robert-André Mauchin from comment #4)
>  - go-bindata only provides a binary, not a library, and only the binary is
> needed for your package. See https://src.fedoraproject.org/rpms/go-bindata
> 
>    So just replace golang(github.com/jteeuwen/go-bindata) with "go-bindata"
> 
>    I'm not even sure you even need it since it's only used in the make
> script that you don't use anyway. It seems to be used only by the developer.
> It's safe to remove imho.

I am going to ask upstream

>  - Where did you get your Version:        2.0.0 from?
> 
> According to
> https://github.com/evilsocket/bettercap-ng/blob/master/core/banner.go the
> latest version is 0.9.

(In reply to Germano Massullo from comment #0)
> [...]
> Note:
> - bettercap-ng was the original project name, that has been changed today
> into bettercap 2.0, more infos at
> https://github.com/evilsocket/bettercap-ng/issues/35

> 
>  - This import path seems dubious:
> 
>  %global import_path     code.google.com/p/go.net
> 
> It's not needed for packaging a binary anyway.

Done

> 
>  - This:
> 
> %doc
> README.md
> 
> %license
> LICENSE.md
> 
>    should be inline, they are not new sections of the SPEC:
> 
> %files
> %doc README.md
> %license LICENSE.md
> %{_bindir}/%{name}

Done

>    Then fix %build:
> 
> %build
> mkdir -p ./_build/src/%{provider}.%{provider_tld}/%{project}
> ln -s $(pwd) ./_build/src/%{provider}.%{provider_tld}/%{project}/%{repo}
> export GOPATH=$(pwd)/_build:%{gopath}
> 
> %gobuild -o %{name} .

Done, but I still obtain some errors

main.go:7:2: cannot find package "github.com/evilsocket/bettercap-ng/core" in
any of:
        /usr/lib/golang/src/github.com/evilsocket/bettercap-ng/core (from
$GOROOT)
       
/builddir/build/BUILD/bettercap-ng-eb1a53efa3171aefed0ec9766d8c5047bd0df289/_build/src/github.com/evilsocket/bettercap-ng/core
(from $GOPATH)
        /usr/share/gocode/src/github.com/evilsocket/bettercap-ng/core
main.go:8:2: cannot find package "github.com/evilsocket/bettercap-ng/log" in
any of:
        /usr/lib/golang/src/github.com/evilsocket/bettercap-ng/log (from
$GOROOT)
       
/builddir/build/BUILD/bettercap-ng-eb1a53efa3171aefed0ec9766d8c5047bd0df289/_build/src/github.com/evilsocket/bettercap-ng/log
(from $GOPATH)
        /usr/share/gocode/src/github.com/evilsocket/bettercap-ng/log
main.go:9:2: cannot find package "github.com/evilsocket/bettercap-ng/modules"
in any of:
        /usr/lib/golang/src/github.com/evilsocket/bettercap-ng/modules (from
$GOROOT)
       
/builddir/build/BUILD/bettercap-ng-eb1a53efa3171aefed0ec9766d8c5047bd0df289/_build/src/github.com/evilsocket/bettercap-ng/modules
(from $GOPATH)
        /usr/share/gocode/src/github.com/evilsocket/bettercap-ng/modules
main.go:10:2: cannot find package "github.com/evilsocket/bettercap-ng/session"
in any of:
        /usr/lib/golang/src/github.com/evilsocket/bettercap-ng/session (from
$GOROOT)
       
/builddir/build/BUILD/bettercap-ng-eb1a53efa3171aefed0ec9766d8c5047bd0df289/_build/src/github.com/evilsocket/bettercap-ng/session
(from $GOPATH)
        /usr/share/gocode/src/github.com/evilsocket/bettercap-ng/session

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to