https://bugzilla.redhat.com/show_bug.cgi?id=1542646



--- Comment #2 from Robert-André Mauchin <zebo...@gmail.com> ---
> %{python2_sitelib}/_patool_configdata.*
This is really an upstream issue, but a package should never ever install
private modules into the top-level namespace. Maybe you can talk with upstream
to move it underneath patoollib/ ?

Wouldn't work currently:

File "/usr/lib/python3.6/site-packages/patoolib/configuration.py", line 5, in
<module>
    import _patool_configdata as configdata

I doubt I'll manage to get upstream to change this as the GIT repo and issue
tracker haven't bulge for 2 years now.

There's also a handful of top-level packages that already exist:

$ ll /usr/lib/python3.6/site-packages/*.py
-rw-r--r--. 1 root root  24K août  31  2014
/usr/lib/python3.6/site-packages/augeas.py
-rw-r--r--. 1 root root  16K févr. 16  2016
/usr/lib/python3.6/site-packages/cycler.py
-rw-r--r--. 1 root root  16K janv. 15  2017
/usr/lib/python3.6/site-packages/decorator.py
-rw-r--r--. 1 root root  39K déc.  24 17:29
/usr/lib/python3.6/site-packages/distro.py
-rw-r--r--. 1 root root  126 nov.  28 16:47
/usr/lib/python3.6/site-packages/easy_install.py
-rw-r--r--. 1 root root  19K juil. 26  2017
/usr/lib/python3.6/site-packages/git_archive_all.py
-rw-r--r--. 1 root root  59K avril  1  2013
/usr/lib/python3.6/site-packages/IPy.py
-rw-r--r--. 1 root root  75K nov.   9 10:24
/usr/lib/python3.6/site-packages/langtable.py
-rw-r--r--. 1 root root 8,2K avril  4  2017
/usr/lib/python3.6/site-packages/magic.py
-rw-r--r--. 1 root root  14K juil. 27  2015
/usr/lib/python3.6/site-packages/ntplib.py
-rw-r--r--. 1 root root 1,1K janv.  6  2017
/usr/lib/python3.6/site-packages/OleFileIO_PL.py
-rw-r--r--. 1 root root 6,2K déc.  15  2015
/usr/lib/python3.6/site-packages/ordered_set.py
-rw-r--r--. 1 root root  87K juin   4  2015
/usr/lib/python3.6/site-packages/pyinotify.py
-rw-r--r--. 1 root root 225K juil. 28  2017
/usr/lib/python3.6/site-packages/pyparsing.py
-rw-r--r--. 1 root root 4,4K août  24  2015
/usr/lib/python3.6/site-packages/requests_file.py
-rw-r--r--. 1 root root 118K juil. 28  2017
/usr/lib/python3.6/site-packages/sh.py
-rw-r--r--. 1 root root  31K sept. 19 15:47
/usr/lib/python3.6/site-packages/six.py
-rw-r--r--. 1 root root 2,9K mars  28  2015
/usr/lib/python3.6/site-packages/sockshandler.py
-rw-r--r--. 1 root root  32K mars  23  2017
/usr/lib/python3.6/site-packages/socks.py
-rw-r--r--. 1 root root 5,0K janv. 13  2011
/usr/lib/python3.6/site-packages/termcolor.py
-rw-r--r--. 1 root root 9,7K déc.   8 16:02
/usr/lib/python3.6/site-packages/tldr.py


I could patch it I guess.


>> %{_datadir}/bash-completion/completions/patool.bash-completion
>This should be called just 'patool', without the extension.

Done.

> Shouldn't this package have Recommends on various tools for all the 
> non-natively-supported formats?

Yes I forgot about this.


Spec URL:
https://raw.githubusercontent.com/eclipseo/packaging/7bf94ea/patool.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/patool/fedora-rawhide-x86_64/00711233-patool/patool-1.12-1.fc28.src.rpm

SPEC diff:
https://github.com/eclipseo/packaging/commit/7bf94eab8915ea4021e01df12059e4aa4e1da804#diff-978fea9b8642e77c470ed419b5f34bfd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to