https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #26 from Antonio Trande <anto.tra...@gmail.com> ---
(In reply to Alexander Ploumistos from comment #25)
> (In reply to Antonio Trande from comment #24)
> > - Openbabel features do not work yet.
> 
> Sorry about the mess, I had been using 2 different machines plus koji and I
> mixed up my files. That's why the spec files don't match.
> 
> The f27 scratch build does work for me and the rawhide build was made from
> the same rpm, so maybe you could try removing 
> ~/.config/SourceForge/Molsketch.conf
> if it's there and try again?

Bingo! It's working now.

> 
>  
> > - ldconfig scriplets are not needed if you install libraries in a private
> > directory.
> 
> And for the devel subpackages they are not needed at all?

Yes.

> 
> 
> > - You're installing duplicate libraries with devel sub-package
> > 
> > Remove
> > 
> > %{_libdir}/%{name}/lib%{name}*so
> > %{_libdir}/%{name}/libobabeliface*so
> 
> And leave only
> %{_includedir}/lib%{name}
> ?

We finally understand what was the problem, then we can separate correctly the
libraries; that is '*.so' in devel and '*.so.*' in main package.

> 
> 
> > - Not all headers are installed; see the list below.
> >   Respect the directories too; for example:
> > 
> >  
> > /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/
> > abstractitemaction.h
> > 
> > is installed as
> > 
> >   /usr/include/libmolsketch/actions/abstractitemaction.h
> > 
> > and so on.
> 
> I am sorry, but I do not understand what I am supposed to do here, could you
> please explain a bit?
> 
> 
> I'll sort through my files tonight, I will add your corrections and submit
> new builds probably tomorrow.

For 'rpmlint' not all the *.h files are installed.
For example,
'/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/obabeliface/obabeliface.h' is not
in the '-devel' subpackage.

You can quickly fix with the attached patch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to