https://bugzilla.redhat.com/show_bug.cgi?id=1542650



--- Comment #3 from Robert-André Mauchin <zebo...@gmail.com> ---

> It looks as though the test binary "test_QEverCloud" is indeed getting built 
> according to the log file. Is it possible to run these in %check?

Good catch. I added the test and it is successful.


> This was recently discussed on the devel list. The takeaway from the change 
> proposal page seems to be that this is fine if you only want to support 
> Fedora 28+, but if you want to backport this to older releases, make sure to 
> add the ldconfig post scriplets (or use the new macros):

I added %ldconfig_scriptlets as I intend to support F27.

> You're missing a 'BuildArch: noarch' for the doc package.

Yes, thank you.

> it should just depend on qt5-qtbase.

-doc now depends on qt5-qtbase.


Spec URL:
https://raw.githubusercontent.com/eclipseo/packaging/9a4c14d/qevercloud.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/quentier/fedora-rawhide-x86_64/00713062-qevercloud/qevercloud-4.0.0-1.fc28.src.rpm

SPEC diff:
https://github.com/eclipseo/packaging/commit/9a4c14d6fc5a25421f7676e895481ef2331cbfa8#diff-a88471a36243d712706fbf604f44a45f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to